fsagbuya commented 2 weeks ago

ARTIQ Pull Request

Description of Changes

Update OpenOCD since the patch for 4-byte address support has already been merged in https://github.com/openocd-org/openocd/commit/be57b0ab847e8246b354ca9203024737cdec403b.

Related Issue

Also fixed the submodules issue and:

Closes #2444

Type of Changes

	Type
✓	:bug: Bug fix
✓	:hammer: Refactoring

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

[x] Use correct spelling and grammar.
[x] Close/update issues.
[x] Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

[x] Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
[x] Test your changes or have someone test them. Mention what was tested and how.
Tested with nix build and nix develop from source without the m-labs binary cache.
```
nix develop --option substitute false
```
[ ] Test in hardware

Git Logistics

[x] Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
[x] Write short & meaningful commit messages. Review each commit for messages (git show). Format:
```
topic: description. < 50 characters total.

Longer description. < 70 characters per line
```

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

sbourdeauducq commented 2 weeks ago

Needs to be tested with hardware.

sbourdeauducq commented 1 week ago

@thomasfire Can you test?

thomasfire commented 1 week ago

nix develop --option substitute false

Cannot check without binary cache - some source servers are down (502). However with binary cache artiq_flash works fine and I am able to ping device after flashing (as usual).

fsagbuya commented 1 week ago

Cannot check without binary cache - some source servers are down (502).

Could you show the error log indicating which server is down? I'll check if it's similar to mine since I also experience this issue with one of the servers sometimes.