SimonRenblad commented 2 weeks ago

ARTIQ Pull Request

Description of Changes

Change MonInj DAC widgets to display the monitored value as a voltage instead of a percentage.

Also changed the text formatting to use square bracket notation for DAC channels, since the previous " ch" format seemed a bit ugly.

Output from artiq_sinara_tester:

Screenshot from 2024-07-04 15-15-32

Type of Changes

	Type
✓	:sparkles: New feature

Steps

All Pull Requests

[x] Use correct spelling and grammar.
[x] Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

[x] Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
[x] Test your changes or have someone test them. Mention what was tested and how. Ran artiq_sinara_tester with a Zotino v1.4.2 connected to a Kasli-SoC v1.1. All values displayed as expected.

Git Logistics

[x] Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
[x] Write short & meaningful commit messages. Review each commit for messages (git show). Format:
```
topic: description. < 50 characters total.

Longer description. < 70 characters per line
```

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

sbourdeauducq commented 2 weeks ago

Not related to this PR, but if would be good to make all the widgets the same size so they align nicely.