m-labs / artiq

A leading-edge control system for quantum information experiments
https://m-labs.hk/artiq
GNU Lesser General Public License v3.0
426 stars 198 forks source link

repeater: clear buffer after ping #2474

Closed Spaqin closed 3 months ago

Spaqin commented 3 months ago

ARTIQ Pull Request

Description of Changes

Bugfix for repeaters for ARTIQ-8+: with multiple AUX buffers there could be a chance that more than one EchoReply packet would be received. Then TSC sync could fail, as it would read a EchoReply packet first rather than TSCAck, so the receiving buffer is cleared before syncing TSC, like in runtime (master) firmware.

Needs to be backported to ARTIQ-8.

Type of Changes

Type
:bug: Bug fix

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

Code Changes

Git Logistics

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

sbourdeauducq commented 3 months ago

Merging this since it's indeed consistent with the master, but I don't actually understand how you could get two EchoReply.