Extract duplicated code from widget classes to new _MoninjWidget base class.
Slightly adjust position of DAC widget value label.
Type of Changes
Type
✓
:sparkles: New feature
Steps
All Pull Requests
[x] Use correct spelling and grammar.
[x] Update RELEASE_NOTES.rst if there are noteworthy changes, especially if there are changes to existing APIs.
[x] Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).
Code Changes
[x] Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
[x] Test your changes or have someone test them. Mention what was tested and how.
See screenshot above. Includes elided titles.
Git Logistics
[x] Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
[x] Write short & meaningful commit messages. Review each commit for messages (git show). Format:
topic: description. < 50 characters total.
Longer description. < 70 characters per line
Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.
ARTIQ Pull Request
Description of Changes
_MoninjWidgetbase class.Type of Changes
Steps
All Pull Requests
git commit --signoff, see copyright).Code Changes
flake8to check code style (follow PEP-8 style).flake8has issues with parsing Migen/gateware code, ignore as necessary.Git Logistics
git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.[x] Write short & meaningful commit messages. Review each commit for messages (
git show). Format:Licensing
See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.