Closed Spaqin closed 3 months ago
I don't think we should use QT_QPA_PLATFORM
in this way. AFAICT it is only used in debug settings to force a specific platform plugin.
On the opposite of what is being done right now, I think we should remove the Wayland check and the -platform xcb
if QT_QPA_PLATFORM
is set to anything.
AFAICT it is only used in debug settings to force a specific platform plugin.
Yes, and we want to force xcb platform plugin; this is more of a guard if the user wanted to. Although probably anyone setting this env variable would know what they're doing.
ARTIQ Pull Request
Description of Changes
Ensures that Wayland is not used, as embedding applets in the GUI is not possible.
Note that the
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
warning is still present, even if by default it wouldn't be used (platformName()
still returns "xcb").Related Issue
2513
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
Code Changes
Git Logistics
git rebase --interactive
). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.[x] Write short & meaningful commit messages. Review each commit for messages (
git show
). Format:Licensing
See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.