m-labs / artiq

A leading-edge control system for quantum information experiments
https://m-labs.hk/artiq
GNU Lesser General Public License v3.0
437 stars 201 forks source link

firmware: Disable the Nagle algorithm on sockets #2612

Closed mbirtwell closed 1 week ago

mbirtwell commented 1 week ago

ARTIQ Pull Request

Description of Changes

Disable the nagle algorithm to fix #2601

The experiment on #2601 goes from about 50ms per RPC to 2.7ms per RPC for me.

Related Issue

Type of Changes

Type
:bug: Bug fix

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

Documentation Changes

Git Logistics

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

thomasfire commented 1 week ago

I checked the patch, works fine. Thanks!

dnadlinger commented 1 week ago

Merged, thanks (having added firmware: to the commit message to make it clear at a glance that this is on the core-device side).