NAC3 Artiq expects every function and class to be in a module which has a file. Kernels submitted by content do not have a file, but their source still needs to be sent to the compiler; so the fake module StringLoader is passed to the compiler. This basically follows the behavior of the legacy compiler as well.
Tested with a Kasli, by submitting kernels with artiq_client, with and without --content option.
Requires changes on the NAC3 side too.
Related Issue
Closes nac3#223
Type of Changes
Type
✓
:bug: Bug fix
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
[x] Use correct spelling and grammar.
Code Changes
[x] Test your changes or have someone test them. Mention what was tested and how.
[x] Add and check docstrings and comments
Git Logistics
[x] Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
[x] Write short & meaningful commit messages. Review each commit for messages (git show). Format:
topic: description. < 50 characters total.
Longer description. < 70 characters per line
Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.
Description of Changes
NAC3 Artiq expects every function and class to be in a module which has a file. Kernels submitted by content do not have a file, but their source still needs to be sent to the compiler; so the fake module
StringLoader
is passed to the compiler. This basically follows the behavior of the legacy compiler as well.Tested with a Kasli, by submitting kernels with artiq_client, with and without
--content
option.Requires changes on the NAC3 side too.
Related Issue
Closes nac3#223
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
Code Changes
Git Logistics
git rebase --interactive
). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.[x] Write short & meaningful commit messages. Review each commit for messages (
git show
). Format:Licensing
See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.