m-labs / artiq

A leading-edge control system for quantum information experiments
https://m-labs.hk/artiq
GNU Lesser General Public License v3.0
437 stars 201 forks source link

NAC3: inject fake module for experiments submitted by content #2622

Closed Spaqin closed 3 days ago

Spaqin commented 5 days ago

Description of Changes

NAC3 Artiq expects every function and class to be in a module which has a file. Kernels submitted by content do not have a file, but their source still needs to be sent to the compiler; so the fake module StringLoader is passed to the compiler. This basically follows the behavior of the legacy compiler as well.

Tested with a Kasli, by submitting kernels with artiq_client, with and without --content option.

Requires changes on the NAC3 side too.

Related Issue

Closes nac3#223

Type of Changes

Type
:bug: Bug fix

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

Code Changes

Git Logistics

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

sbourdeauducq commented 3 days ago

Closes nac3#223

I suppose you mean #226.