search

m-labs / migen

A Python toolbox for building complex digital hardware
https://m-labs.hk/migen
Other
1.23k stars 210 forks source link

fhdl/structure: add check for equality for _Slice #292

Open maass-hamburg opened 2 months ago

maass-hamburg commented 2 months ago

add check for equality for _Slice.

maass-hamburg commented 2 months ago

@sbourdeauducq you may want to take a look

maass-hamburg commented 1 month ago

@m-labs please take a look

sbourdeauducq commented 1 month ago

See the comment above the code you modified. At the very least it would need to be updated. But what is the rationale for this change?

maass-hamburg commented 4 weeks ago

@sbourdeauducq the reason for that change is demonstated here: https://github.com/enjoy-digital/litex/pull/2074/commits/d63d8d99dfe5865fc3438bdc6c9e6733b9597228. There oe1 and oe2 could be Slices and without this change, we would get a Error.