search

m-labs / nmigen-boards

Board and connector definition files for nMigen
Other
29 stars 13 forks source link

Make oe in SRAMResource optional. #26

Closed cr1901 closed 5 years ago

cr1901 commented 5 years ago

As requested. This is a breaking change because the order of arguments to SRAMResource changed by making oe optional.

whitequark commented 5 years ago

It is not breaking, all *Resource arguments are keyword-only.

whitequark commented 5 years ago

And you don't even need to reorder them in the definition, def x(*, a=None, b): pass is valid Python.