search

m-labs / nmigen

A refreshed Python toolbox for building complex digital hardware. See https://gitlab.com/nmigen/nmigen
https://nmigen.org
Other
646 stars 55 forks source link

build.dsl: allow strings to be used as connector numbers #313

Closed anuejn closed 4 years ago

anuejn commented 4 years ago

follow up of #311 . Is it as simple as that or did I miss something?

codecov[bot] commented 4 years ago

Codecov Report

Merging #313 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          34       34           
  Lines        5659     5659           
  Branches     1163     1163           
=======================================
  Hits         4646     4646           
  Misses        862      862           
  Partials      151      151
Impacted Files Coverage Δ
nmigen/build/dsl.py 93.75% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c42c3a0...04b8ee5. Read the comment docs.

whitequark commented 4 years ago

Merged in my fork.

sbourdeauducq commented 4 years ago

Merged upstream.