m-labs / pdq

Pretty darn quick interpolating arbitrary waveform generator
GNU General Public License v3.0
6 stars 3 forks source link

What modifications would need to be made to allow for more than 32 frames? #17

Closed erickson-nist closed 7 years ago

erickson-nist commented 7 years ago

We are likely to run out of memory before filling all 32 frames with transport waveforms, but our pulse shapping waveforms are much simpler/smaller. The number of frames could be more limiting than memory in that instance, so we may in the future want more frames.

My attempt to allow for more frames failed. I tried changing gateware/dac.py line 68 to self.frame=Signal(max=64) then recompiled the gateware and flashed a pdq.

@jordens do you have any intuition on what else we would need to change to make this work? My understanding is the SPI communication only sends 4 bits for the frame select, so increasing the max number of frames would require modifying it as well.

jordens commented 7 years ago

There is an equivalent line in comm.py that needs changing as well. And the documentation. Then you can use up to 256 frames.

jordens commented 7 years ago

@erickson-nist ping. can we close this?

erickson-nist commented 7 years ago

Sorry, yes we can.

jordens commented 7 years ago

no problem. thanks!