m-lundberg / simple-pid

A simple and easy to use PID controller in Python
MIT License
801 stars 217 forks source link

add a random CrazyBoiler #21

Closed Supegg closed 4 years ago

m-lundberg commented 4 years ago

Sorry it has taken me so long to get to this. I have decided that I will not accept this PR since I don't think it adds much. I made the water boiler example as a very simple example to show users how to use the API that this library provides in a simple case. Adding another boiler class with some randomness as the only difference does not help explain anything to the user that the regular boiler class doesn't already, and it makes the example file quite a bit longer which I think could lead to new users feeling more overwhelmed if they go to look at the example. I prefer it to remain as short and to the point as possible while also showing a complete usage of the PID class.

I hope you understand my reasoning for closing this. Thanks again for taking the time with this PR.