search

m-lundberg / simple-pid

A simple and easy to use PID controller in Python
MIT License
799 stars 217 forks source link

Added option derivative on measurement #41

Closed kmodexc closed 2 years ago

kmodexc commented 3 years ago

To give the user the option to use a traditional PID controller instead of the more advanced version from brett beauregard i added the option differential_on_measurement.

closes #39

m-lundberg commented 2 years ago

And also, could you please add a note under the relevant section in CHANGELOG.md?

shenxiangzhuang commented 2 years ago

Hi! I think this option parameter is good for unnecessary misunderstanding about the implementation, and I will be happy that this PR can be merged as early as possible. Would you mind that I solve the conflict and add new PR to merge? @m-lundberg

shenxiangzhuang commented 2 years ago

Hi! I think this option parameter is good for unnecessary misunderstanding about the implementation, and I will be happy that this PR can be merged as early as possible. Would you mind that I solve the conflict and add new PR to merge? @m-lundberg

Or if @kmodexc can notice the message and solve the conflict would be better.

kmodexc commented 2 years ago

Sry im doing that in the next days. Totally forgot about it.

kmodexc commented 2 years ago

done

kmodexc commented 2 years ago

@m-lundberg

kmodexc commented 2 years ago

Im not doing this a second time

m-lundberg commented 2 years ago

Merged! Thanks for your patience, it's not always easy to find the time.