Closed rnestler closed 2 years ago
When I use from simple_pid import PID and check the code with mypy --strict I get the following error:
from simple_pid import PID
mypy --strict
$ mypy --strict test.py test.py:1: error: Module "simple_pid" does not explicitly export attribute "PID"; implicit reexport disabled
I guess this is an issue with the from .PID import PID in __init__.py? If I change it to from .PID import PID as PID it works.
from .PID import PID
__init__.py
from .PID import PID as PID
Also I think it is strange that the import in __init__.py shadows the PID module in simple_pid.
PID
simple_pid
Maybe it would be better to rename the module to pid?
pid
When I use
from simple_pid import PIDand check the code withmypy --strictI get the following error:I guess this is an issue with the
from .PID import PIDin__init__.py? If I change it tofrom .PID import PID as PIDit works.Also I think it is strange that the import in
__init__.pyshadows thePIDmodule insimple_pid.Maybe it would be better to rename the module to
pid?