search

m-lundberg / simple-pid

A simple and easy to use PID controller in Python
MIT License
767 stars 209 forks source link

Rename PID module #53

Closed m-lundberg closed 2 years ago

m-lundberg commented 2 years ago

As mentioned in #48, calling the module PID.py is not very appropriate. To follow pep 8 it should be called pid.py instead. Think about how breaking this change would be and possibly rename the module.

rnestler commented 2 years ago

Think about how breaking this change would be and possibly rename the module.

I'm not sure if it is really breaking, since the module currently can't get imported since it is shadowed by the re-export of the PID class.