search

m-lundberg / simple-pid

A simple and easy to use PID controller in Python
MIT License
767 stars 209 forks source link

CI: add a workflow to run examples #60

Closed mrakitin closed 1 year ago

mrakitin commented 2 years ago

This is prompted by the report in #59. The new workflow is supposed to run for Python 3.7-3.10 (there is no NumPy 1.21 version for Python 3.6) and produce plots after running the water_boiler.py example. The resulting plots are then uploaded to GHA's summary page (in a .zip archive) so that one can see the results of the run.

mrakitin commented 2 years ago

@hamedhkme, check if the steps outlined in this PR help to resolve your example running issue reported in #59.

mrakitin commented 2 years ago

The review comments were addressed. Thanks for your review, @m-lundberg!

mrakitin commented 2 years ago

The failure for the "examples" job for Python 3.7 is due to NumPy 1.22 does not exist on PyPI for that version of Python. What do you want to do about that? Relaxation of NumPy version requirement, or exclusion of Python 3.7 from the test matrix?

m-lundberg commented 1 year ago

The failure for the "examples" job for Python 3.7 is due to NumPy 1.22 does not exist on PyPI for that version of Python. What do you want to do about that? Relaxation of NumPy version requirement, or exclusion of Python 3.7 from the test matrix?

I think for the examples it's fine to not run them in Python 3.7. The result should be the same regardless of Python version anyway.

mrakitin commented 1 year ago

Thank you, @m-lundberg! Sorry I did not have time to incorporate your suggestion. I hope it's not a problem.

m-lundberg commented 1 year ago

It's no problem at all!