search

m-lundberg / simple-pid

A simple and easy to use PID controller in Python
MIT License
767 stars 209 forks source link

Provide Circuitpython compatibility by removing warning module #63

Closed eirinnm closed 1 year ago

eirinnm commented 2 years ago

The warning module is only used once in this library, and isn't needed at all IMHO. Removing it makes this library compatible with CircuitPython.

m-lundberg commented 1 year ago

Hi! I have never used CircuitPython or MicroPython myself, so I'm not sure what else would be needed (if anything) to successfully use this project on those platforms. This can be tracked in #64 (if you have any more insight into this, please feel free to make a comment there).

But I agree that this warning is not completely necessary, and if it makes this library more compatible I think it's a good idea to remove it.