Not removing song lyrics in star sign - Githubissues

m-lyon / filter-subs

Filter Subtitles to remove SDH entries

MIT License

38 stars 9 forks source link

Not removing song lyrics in star sign #26

Open seadogro opened 3 months ago

seadogro commented 3 months ago

Input Before: 853 00:40:14,010 --> 00:40:15,080 Aah!

854 00:40:15,110 --> 00:40:18,580

she walked up to me and she asked me to dance *

855 00:40:18,610 --> 00:40:20,050

I asked her her name

856 00:40:20,080 --> 00:40:23,220

and in a dark brown voice she said Lola *

857 00:40:23,250 --> 00:40:26,090 I told you you shouldn't have shot my friend.

858 00:40:26,120 --> 00:40:30,090 Oh, by the way, your fly's been down the whole time.

After: 791 00:40:14,010 --> 00:40:15,080 Aah!

792 00:40:18,610 --> 00:40:20,050 * I asked her her name

793 00:40:23,250 --> 00:40:26,090 I told you you shouldn't have shot my friend.

794 00:40:26,120 --> 00:40:30,090 Oh, by the way, your fly's been down the whole time.

As you see it not removed the single song lyrics line "I asked her her name" Please fix that it delete single lines with star sign * which basically means song lyrics as well.

Thank you.

allgreed commented 3 months ago

@seadogro would you be so kind as to wrap the examples in code blocks? Also: I'm not sure that song lyrics are always a thing to be removed, sometimes it's crucial to the plot and the singers don't sing very clearly

seadogro commented 3 months ago

@seadogro would you be so kind as to wrap the examples in code blocks? Also: I'm not sure that song lyrics are always a thing to be removed, sometimes it's crucial to the plot and the singers don't sing very clearly not working. Here on pastebin: https://pastebin.com/UUyuSCBW

m-lyon commented 3 months ago

Similarly to #28, because there is no trailing asterisk, and the need to capture multiline patterns, it's not trivial to fix this.