#18: Loading classes from external Maven project

m-m-m / code

Library to parse, analyze, transform and generate code

Apache License 2.0

2 stars 3 forks source link

#18: Loading classes from external Maven project #19

Closed hohwille closed 5 years ago

hohwille commented 5 years ago

Replacement for #18 with review rework.

hohwille commented 5 years ago

There wre several bugs that I now fixed. Especially the parent classloader was wrong and there were errors with duplicate packages that did not occur with the simple JUnit. What is still kind of wrong is that both the JAR as well as the classes folder is added for modules. We can fix that later. I now consider this ready to be merged.

hohwille commented 5 years ago

Mhm, there are several more bugs. E.g. the modules of a module are not considered. In general there also needs to be a set of modules that have already been visited to avoid reading the same module multiple times.

hohwille commented 5 years ago

Also the modules are all added as dependencies even though they might be unrelated to the current maven project. This is also dead wrong.