Open nolanhergert opened 9 years ago
For the first item, is it appropriate to add -pthread
to both Makefile-Debug and Makefile-Release? I am just hoping it won't screw up things for other OS's as you Matt obviously didn't need it.
I'll try adding pthread when I'm working on this library next. I don't think it will have any affect on other platforms, where it's probably (hopefully!) just ignored. I've not yet tried flashee on OSX, which is now my day-to-day platform.
There are two issues.
1. gtest.h requires pthread support
Fix: Add pthread support flag to Makefile Specifically, I appended "-pthread" to the CXXFLAGS option (line 59) of firmware/test/nbproject/Makefile-Debug.mk. One should also add this to the release build appropriately.
2. Some tests fail