m-novikov / tree-sitter-sql

SQL syntax highlighting for tree-sitter
MIT License
112 stars 33 forks source link

Support more syntax #22

Closed pplam closed 2 years ago

pplam commented 2 years ago

New supportings

Improvements

m-novikov commented 2 years ago

Thank you for the PR :) This needs more tests as otherwise there is a probability of unexpected breakage of introduced syntax. Existing tests can be updated with a command

tree-sitter test -u

It will update existing tests to match current output but use it sparingly.

m-novikov commented 2 years ago

Hey, I took a couple of patches from your PR attributed to you in the commits e.g https://github.com/m-novikov/tree-sitter-sql/commit/0d3cde974e5376fc89e87bf34905b1c4f242d8fe Thanks a lot.

Currently, I am working on an external parser for dollar-quoted strings.

Overall it would be simpler for me to merge stuff with smaller PRs, because I also working on some parts and for example unary expressions were helpful.

pplam commented 2 years ago

It's good practice to create small PRs, next time i will submit as small PR as possible

pplam commented 2 years ago

Thank you for the PR :) This needs more tests as otherwise there is a probability of unexpected breakage of introduced syntax. Existing tests can be updated with a command

tree-sitter test -u

It will update existing tests to match current output but use it sparingly.

Hi @m-novikov , I just resolved all conflicts and rewrote the git history.

And also add test for each changed/added rule.

Please review this PR again, thanks!