Ubuntu build fix - Githubissues

m-schuetz / SimLOD

MIT License

454 stars 24 forks source link

Ubuntu build fix #2

Closed MrNeRF closed 9 months ago

MrNeRF commented 10 months ago

CMAKE version down (does not use recent features. Why raising the bar)?
Set debug option for debug build. Makes it use breakpoints.
Specify default build type of not set.
Remove under linux unnecessary nvidia libs that cause linking errors..
Does not crash anymore when CUDA PATH is not set.
Small refactoring.

m-schuetz commented 10 months ago

Thanks! It will take some time to merge this because I'm on vacation until end of november.

m-schuetz commented 9 months ago

Looks good to me, what about you @JolifantoBambla ?

JolifantoBambla commented 9 months ago

Looks good but according to the docs, the CUDA targets nvrtc_static and nvrtc_builtins_static which the Windows build links against are only available with CMake version 2.26. I think the Windows build linking against the two is a remnant anyway - if we remove them from the CMakeLists, I think lowering the CMake version is fine.

MrNeRF commented 9 months ago

You want me to do it? I can remove the nvrtc stuff but I don't run any Windows installation so I cannot assure if the change breaks something or not.

m-schuetz commented 9 months ago

That's fine, I'll check it out for windows. I'm just curious whether nvrtc_static might be required for windows build to make it run on systems without a CUDA installation. The NVRTC docs make it sound a bit like we'll either have to ship the binaries with dlls, or we'll have to include the static lib.

https://docs.nvidia.com/cuda/nvrtc/index.html

MrNeRF commented 9 months ago

I made a clean rebuild. On linux it works. But the change didn't really affect my system. Hope it also works on windows.

m-schuetz commented 9 months ago

Just checked it and it works fine for windows. Thanks for the PR!