search

m-talbi / catalog-of-things

Catalog Of My Things is a command-line interface (CLI) application designed for users to conveniently manage their collections of books, music albums, movies, and games. This easy-to-use app stores data in JSON files, allowing users to easily add, delete, and update information about their personal belongings all in one place.
0 stars 0 forks source link

Review Kanban #6

Open m-talbi opened 1 year ago

m-talbi commented 1 year ago
prolajumokeoni commented 1 year ago

Hi @Kweeka1, @belalgamal46 and @Htetaungkyaw71,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not have a Github project(kanban board), the link you have submitted above in your issue description is the link to your Github repository please create and add the GitHub project(kanban board) to your issue description 👍🏿

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

prolajumokeoni commented 1 year ago

Hi @Kweeka1, @belalgamal46 and @Htetaungkyaw71, please make your github project(kanban board) public Screenshot_701

m-talbi commented 1 year ago

Hey @prolajumokeoni. Could you try opening the link again. I've changed the visibility to public.

prolajumokeoni commented 1 year ago

Hi @Kweeka1, @belalgamal46 and @Htetaungkyaw71, Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️Good issue description

Required Changes ♻️

This will help to achieve the tasks easier and faster because you have broken the project into smaller tasks

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

gemmen29 commented 1 year ago

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights 💯

Optional suggestions

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.