search

m-toman / tacorn

2018/2019 TTS framework integrating state of the art open source methods
MIT License
47 stars 4 forks source link

bug fix about input sentences in synthesis time #7

Closed Yeongtae closed 5 years ago

Yeongtae commented 5 years ago

bug fix about input sentences

m-toman commented 5 years ago

Thank you for the PR. I don't really see why there is a difference in the path in map.txt whether "sentences" are load from file or not - in both cases "sentences" just holds a list of strings. Why is this https://github.com/m-toman/tacorn/pull/7/files#diff-e708a1edee0341db7024711a45e66550R63 necessary?

Yeongtae commented 5 years ago

When old version generates a wave file after generating n wave files, it generates n wave files.

m-toman commented 5 years ago

You are right that this should be fixed.

But why do we need to do os.path.join(args.mels_dir, m) to load the mels in case the sentences come from an input file and just m when not?

Yeongtae commented 5 years ago

You are right. When I implement it, I had some mistake.

So I fixed it and had done to test it.