Doesnt work on minified version using angular-yeoman

[luispeerez]

The directive template is inserted on the DOM but when I click on an image the photoswipe gallery doesn't show.

In the minified version of my yeoman proyect I can see the Photoswipe and ng-photoswipe code.

[m00s]

Hi @luispeerez, thanks for you're feedback.

Are you doing something similar to what shown in the demo here?

Is your code open-source? Or can you post here a snippet or take a few minutes to build a plunk? It would helps me to help you..

[cguilhermef]

We had the same problem here. After one hard day of 'console.logs' and tests, we found an issue in the use of property 'open', in the directive script. I replace 'open' by 'show', and it works. Why? We don't know.

I've forked this project and will make a pull request to change this.

[cguilhermef]

Pull request with the modify proposed.

[luispeerez]

@cguilhermef Thank you, it finally worked with your solution

[gabovanlugo]

@cguilhermef Thank you so much. I was facing the same problem.

[ginanjarfm]

Hi @m00s, how about this issue?

I tried @cguilhermef 's solution but it doesn't work for me. (change open with show)

[cguilhermef]

@ginanjar-fahrul-m , do you tried using my pull-requested commit? I had change some lines of code to offer show attribute.

[ginanjarfm]

@cguilhermef Thank you so much. Now, finally worked.

[luispeerez]

The pull request isn't accepted yet?

[nhim175]

The open attribute is a conflict with standard HTML attribute -> the value got removed after the code being complied.

[nhim175]

I replace 'open' by 'show', and it works. Why? We don't know.

@cguilhermef https://www.w3schools.com/tags/att_details_open.asp As I explained above, I used to have some problem with the compact attribute as well.

[cguilhermef]

Hmm <details> is a new tag for me.