search

m0bilebtw / c-engineer-completed

Have C Engineer personally announce your achievements!
BSD 2-Clause "Simplified" License
9 stars 21 forks source link

Overlapping level-ups freezing Runelite #23

Closed GoldenBeanos closed 11 months ago

GoldenBeanos commented 11 months ago

Getting several level-ups back to back due to leagues causes Runelite to freeze until the previous sound snippet has ended. Causing severe noticeable lag spikes cutting into gameplay.

m0bilebtw commented 11 months ago

When did you last restart runelite? I've released an update that should've fixed this already

GoldenBeanos commented 11 months ago

Ah, I haven't restarted for a few hours I'll do that! Thank you very much!

m0bilebtw commented 11 months ago

Please let me know if it still happens after the restart

pwatts6060 commented 11 months ago

On the Tedious Collection Log fork there is considerable lag when the plugin announces the collection log. Best way to test this is buying and selling items at castle wars for collection log items. You'll notice the lag when you try buy the next piece after the collection log announcement. @evaan The issue isn't present in the C Engineer: Completed plugin however.

I posted the issue here since their fork doesn't have an issues tab.

C Engineer: https://i.gyazo.com/0ad0089e7358d20c1fdce30818833c05.gif

Tedious: https://i.gyazo.com/0ad0089e7358d20c1fdce30818833c05.gif

m0bilebtw commented 11 months ago

It makes sense this issue is still present in the tedious plugin as they forked off of this plugin a long time ago but I only fixed the issue a couple of days ago. I'm not the maintainer of the tedious plugin but they're welcome to reference the change I made here recently to resolve the issue there too.

Thanks for additional confirmation that the fix is indeed working, closing this issue