search

m0bilebtw / skills-tab-progress-bars

A RuneLite plugin to add progress bars in the skills tab
BSD 2-Clause "Simplified" License
9 stars 8 forks source link

Plugin seems to do nothing on initial install #3

Closed Enriath closed 4 years ago

Enriath commented 4 years ago

When I first used the plugin, I was kinda annoyed that it only seemed to show a bar for the skill I was training. Later, when I reinstalled, it didn't show a bar for any skill.

You'll want to add some code to startUp to get all the current XP values and make the bars from that. That way, people who install the plugin whilst logged in don't get confused and potentially not use a really cool plugin.

m0bilebtw commented 4 years ago

A very good point I'd overlooked. What's happening currently is I'm listening to any changes in xp, which come through when a player logs in as well as when a player gains any xp, and had left it at that not thinking about when a user is already logged in upon installation. Thanks for bringing this up, will sort this out soon.

On Fri, 3 Apr 2020, 7:29 am Hydrox, notifications@github.com wrote:

When I first used the plugin, I was kinda annoyed that it only seemed to show a bar for the skill I was training. Later, when I reinstalled, it didn't show a bar for any skill.

You'll want to add some code to startUp to get all the current XP values and make the bars from that. That way, people who install the plugin whilst logged in don't get confused and potentially not use a really cool plugin.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/m0bilebtw/skills-tab-progress-bars/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO33FZA2VA234HTL5652CLTRKV657ANCNFSM4L3QICFA .