search

m0bilebtw / skills-tab-progress-bars

A RuneLite plugin to add progress bars in the skills tab
BSD 2-Clause "Simplified" License
9 stars 8 forks source link

Option to not hide other bars when hovering #7

Closed yani closed 2 years ago

yani commented 4 years ago

I don't mind all bars to be visible when hovering over the skills.

Could it be possible to add an option for this?

m0bilebtw commented 4 years ago

The problem with showing the progress bars when hovering skills is that the in-game tooltip showing current XP, next level XP, etc. is covered by the bars of other skills.

I need to tell runelite on which layer to draw this overlay, and there exists no layer that is above the skills themselves but beneath the tooltips. As such, the bars get in the way of reading the tooltips. This was first discussed in issue #1 if you're interested. The ideal solution would be runelite to add a layer that would be between the skill widgets and the tooltip widget that shows on hover, but when I asked they had no intention of doing this.

Given that the bars absolutely would be in-front of the skill hover tooltips looking messy, and sometimes making reading the tooltip text difficult depending on settings, is this still a toggle you really want?

yani commented 4 years ago

I thought about that as well, but I did not know you looked this hard into it. Do you think it's possible to change the layer of the hover info itself, as a workaround? I can't look that much into it myself right now.

Or maybe having a list of what skill is being hovered and what exp bars are behind the hover info to hide only those?

m0bilebtw commented 4 years ago

I don't think changing the layer of the tooltip with xp info is feasible, but I'd be happy to be proven wrong.

Accounting for the specific skills that are covered by other skills tooltips would be somewhat messy - to support changing settings, maxed and non-maxed skills, etc. each skill would need a corresponding collection of 3 to 6 other skills, which would need to be checked every time the overlay is drawn while any one skill is being hovered. It's possible, but seems messy, inefficient, not necessarily worth the benefit of simply having fewer bars hide when hovering a skill.

I'm not saying it won't happen, or that there isn't some other better solution, just that I'm not confident it's a good thing to do yet.

prxsto commented 3 years ago

I'm wondering if the opposite is possible: is it possible to add a toggle so that it only shows the visual progress bar for a specific skill when hovered?

m0bilebtw commented 3 years ago

That's doable for sure, separate to this issue. Will implement soon.

m0bilebtw commented 3 years ago

I'm wondering if the opposite is possible: is it possible to add a toggle so that it only shows the visual progress bar for a specific skill when hovered?

@prxsto Have updated the plugin, will be submitting the update to plugin-hub shortly, where there is a toggle which when enabled will only show progress bar for the skill you are currently hovering. This does not affect this issue though, still no ideal solution.

Enriath commented 2 years ago

How would you feel about a rewrite that replaces the overlay with Jagex widgets instead? This would fix the layering thing, though a lot of the plugin would change.

If so, I'd be willing to do it; I've done way too many projects with the Jagex widget system, so I could probably bash it out in an afternoon.

m0bilebtw commented 2 years ago

How would you feel about a rewrite that replaces the overlay with Jagex widgets instead? This would fix the layering thing, though a lot of the plugin would change.

If so, I'd be willing to do it; I've done way too many projects with the Jagex widget system, so I could probably bash it out in an afternoon.

That sounds good! I wasn't aware that was an option but it sounds like the better option for this plugin.