m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Create pro keys preview logic #136

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
With vocal charting becoming even more popular, having a standard notational 
display for PART VOCALS would be convenient, especially when transcribing from 
sheet music.  Even people that can't read sheet music would be able to beat 
sync and then just place the notes as they appear on the sheet.

In addition, standard notation will probably be the best way to display notes 
in a PART KEYS track if it is ever implemented in EOF.  Even if FoFiX doesn't 
get support for a very long time or ever, if EOF supports charting it, I'm sure 
some of the current-gen rhythm games being developed (ie. Phase Shift) may add 
support.

Some usable (free/open source) graphics are here:
http://commons.wikimedia.org/wiki/File:G-clef.svg
http://commons.wikimedia.org/wiki/File:FClef.svg
http://commons.wikimedia.org/wiki/User:%E3%81%A3/%E9%81%93%E5%85%B7%E7%AE%B1/%E7
%A0%82%E5%A0%B4

The most difficult part will be to cram a grand staff in the relatively-short 
height of the editor window.  Perhaps there could be a toggle-able option to 
clip the grand staff view so that the beat marker arrows become available.  
Otherwise, the space used by the arrows could be used to allow for more 
luxurious space.  If this was implemented, manipulation of the beat markers 
would have to be disabled when the beat arrows are not visible.

Adding the other clef markers for when the piano roll area is re-focused would 
be a plus, but is not likely to be used as much.

Original issue reported on code.google.com by raynebc on 30 Jul 2010 at 11:39

GoogleCodeExporter commented 8 years ago
In addition to a new render function, there would need to be a new edit logic 
function as well.  All notes entered in a PART KEYS style track would need to 
be allowed to overlap, so forcing notes in such a track to have "crazy" status 
would be a quick way to avoid having to add logic to exempt this track from 
cleanup code that would remove the overlapping notes.

We can either decide to draw some of the music notation items (such as notes, 
quarter notes, etc) or we can use ones that are readily available, such as from 
the Wikimedia Commons site.

A new preview window function may also be a good idea, this would be an great 
place to implement a previous enhancement request of mine to implement a 
"falling keys" style preview, similar to how notes are presented in Rock Band 3 
or Synthesia.  Such a preview function could use much of the existing full 
piano logic, as this would be a great way to allow users to enter notes besides 
manipulating within the editor window.

Original comment by raynebc on 31 Aug 2010 at 5:12

GoogleCodeExporter commented 8 years ago
r388 consolidates duplicated editor window logic into 
eof_render_editor_window_common() and eof_render_editor_window_common2().  This 
will allow much of the code to be reused easily (ie. drawing the beat markers, 
second markers, etc).

Original comment by raynebc on 23 Sep 2010 at 4:52

GoogleCodeExporter commented 8 years ago
Looking back at this now, I don't feel that a grand staff view would offer many 
benefits over a standard piano roll view, especially given how much more 
complicated it would be to program.  I think the falling note style of pro keys 
preview still has merit and would be great for previewing a pro keys track.  An 
eof_note_draw_piano() function, which could be called in the full piano panel 
preview, could make this easy to accomplish.  This could remain a low priority 
enhancement until pro keys authoring is implemented.

Original comment by raynebc on 8 Feb 2011 at 7:26

GoogleCodeExporter commented 8 years ago

Original comment by raynebc on 26 Jul 2012 at 7:15