Future-proof the legacy import

[GoogleCodeExporter]

The use of global macros in legacy.c would cause problems if the values of 
those macros were altered.  The legacy EOF file open functions should probably 
be changed to process a specific number of tracks and notes.  This way, when 
large changes are made (such as adding support for extra instrument/vocal 
tracks), it won't break the ability to open legacy EOF files.

Original issue reported on code.google.com by raynebc on 15 Aug 2010 at 6:34

[GoogleCodeExporter]

For the sake of readability and accuracy, perhaps the macros (ie. 
EOF_MAX_TRACKS) could be redefined with non macro constant values within each 
of the switch cases (each different version of the format).  If this isn't 
doable, then the macros can just be replaced with variables instead.

Original comment by raynebc on 31 Aug 2010 at 8:48

[GoogleCodeExporter]

This should probably be changed before any other major changes that would 
affect global macro values (such as adding additional tracks, difficulties or 
fret lanes).

Original comment by raynebc on 8 Sep 2010 at 3:49

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Since macros can't be defined with a different value without undefining them 
first, I am using variables for this.

Original comment by raynebc on 8 Sep 2010 at 11:17

• Changed state: Started

[GoogleCodeExporter]

Completed in r359.

Original comment by raynebc on 9 Sep 2010 at 6:37

• Changed state: Fixed