m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Display vocal note slides #147

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I was reading Harmonix's documentation a bit while ironing out some of the 
grouping logic details regarding pitch shifts, and found that the speed of the 
shift between notes depends on the space between when the syllable's note stops 
and the shift's note starts.  It would be useful for EOF to draw a diagonal 
line to connect a pitch shift's note to the previous lyric's note.

Original issue reported on code.google.com by raynebc on 24 Aug 2010 at 8:12

GoogleCodeExporter commented 9 years ago
It would also be kind of neat if EOF could alter the pitch of vocal tones for 
partial steps between notes during the slides, but this wouldn't work well for 
timbres that attenuate until they are silent (such as a piano voice).  Synth 
tones that stay the same volume regardless of how long they play may work for 
this.

Original comment by raynebc on 26 Aug 2010 at 8:40

GoogleCodeExporter commented 9 years ago

Original comment by raynebc on 1 Sep 2010 at 4:29

GoogleCodeExporter commented 9 years ago
Started in r390.  Diagonal rectangles are rendered between one lyric rectangle 
and the next lyric if the next lyric begins with '+'.  If there is a better 
function to draw a filled rectangle, it should probably be used, because quite 
a bit of the rendered slide rectangle is NOT filled in properly.

We can decide whether or not it would be feasible to alter the pitch of tone 
samples to suit vocal slides.  It may be too complicated to be worthwhile.

Original comment by raynebc on 23 Sep 2010 at 11:57

GoogleCodeExporter commented 9 years ago
There seems to be some kind of graphical glitch with one of my charts:
http://www.sendspace.com/file/1agot0

If I seek to measure marker 264 in PART VOCALS and zoom in, there is a vocal 
slide artifact on screen centered over C#5 at various zoom levels, even though 
there are no lyrics there.

I'm changing this issue to defect until this is corrected.

Original comment by raynebc on 24 Sep 2010 at 12:41

GoogleCodeExporter commented 9 years ago
The noteless slide glitch was corrected in r392.

I'll try to look into how to add the audio pitch slide effect to vocal tones, 
in case it can be done without massively complex logic.

Original comment by raynebc on 24 Sep 2010 at 2:39

GoogleCodeExporter commented 9 years ago
I don't think it's going to be useful to try to alter the pitch of the playing 
cue, as the cues aren't designed to play indefinitely, so they can't be counted 
on to play long enough to have a pitch change make a difference.

The audio part of this enhancement can be dismissed and once documented, the 
visual part of this enhancement can be considered complete.

Original comment by raynebc on 27 Sep 2010 at 6:25

GoogleCodeExporter commented 9 years ago
Completed in r408.

Original comment by raynebc on 28 Sep 2010 at 11:40