m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Consolidate command line loading code #156

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently, there is a large overlap in logic between loading files via command 
line versus via EOF's menu.  It's a little troubling that at first glance, some 
variable initialization doesn't seem consistent between the two.  I think that 
it would be beneficial for eof_import_midi() and eof_load_song() to either 
perform the follow up initialization or call upon another function to do so.  
This will allow eof_initialize() to be simplified and make it easier to add the 
loading of other files via command line (ie. Feedback charts).

Original issue reported on code.google.com by raynebc on 7 Sep 2010 at 8:18

GoogleCodeExporter commented 9 years ago
r354 begins work on this issue.  The common initialization logic at the end of 
command line import could probably be put into a function that gets called by 
each format's import routine.  This would make it easier to be consistent.

Original comment by raynebc on 7 Sep 2010 at 8:49

GoogleCodeExporter commented 9 years ago
Besides the import functions, eof_menu_file_new_wizard() also has the same kind 
of variable initialization.

Original comment by raynebc on 7 Sep 2010 at 11:00

GoogleCodeExporter commented 9 years ago
Completed in r358.

Original comment by raynebc on 8 Sep 2010 at 6:35