m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Add support for a sixth lane #158

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Initially, this is to suit issue 116.  Ultimately, this will probably be 
necessary for charting "pro" guitar tracks.

This would require many changes to EOF, including a new revision of the EOF 
chart format.  Since it will have to be changed, this would be a good time to 
add other items to the format, such as fret numbers (one number for each guitar 
string).

Original issue reported on code.google.com by raynebc on 8 Sep 2010 at 2:50

GoogleCodeExporter commented 9 years ago
If the Rock Band 3 drum extension allows the cymbals to be recognized separate 
from the other drum pads, drum simulation games like DTX Mania may become even 
more popular, as it allows for 8 lane drum charts.  The Rock Band 3 extension 
would cause the drum controller to have 3 cymbals, 4 pads and at least one 
pedal.  Supposedly it includes a hi-hat pedal.  If there is demand, it may be a 
popular idea for EOF to support creating such elaborate drum charts, although 
the chart format used by DTX Mania was quite different from the MIDI format 
we're used to and would probably require some elaborate conversion logic.

Original comment by raynebc on 13 Sep 2010 at 9:13

GoogleCodeExporter commented 9 years ago
Since EOF now supports charting pro mode drums (which doesn't require 
additional lanes), this feature will ultimately be needed for pro guitar 
charting.  While we're at it, if we can make it support an arbitrary number of 
lanes, we'll be able to add 8 lane drum support (for DTXMania style drum 
charts).

Original comment by raynebc on 28 Oct 2010 at 12:18

GoogleCodeExporter commented 9 years ago
I'll begin by changing the EOF_MAX_FRETS macro to a value of 6, and then 
adapting the logic to use a per-track definition of how many lanes are used.  
Adding logic to help simplify how to identify screen coordinates for each lane 
would probably help with issue 211 (which needs to allow separate crazy notes 
to be able to start at the same position but be individually selectable by 
clicking on an individual gem).

Original comment by raynebc on 3 Dec 2010 at 6:19

GoogleCodeExporter commented 9 years ago
r609 begins this work.  The updated logic for the note and fretboard rendering 
can be moved into a new function so that the code can be re-used for the fret 
catalog rendering.  After this, we could start work on issue 116 by adding a 
menu function to change the lane count in PART BASS from 5 to 6.

Original comment by raynebc on 3 Dec 2010 at 11:57

GoogleCodeExporter commented 9 years ago
r617 adds graphics for an orange note that can be used for lane 6 when it comes 
to creating 6 lane drums or pro guitar.

Open bass notes are allowed to be entered in lane 6 (for issue 116), but the 
note rendering that occurs when mousing over existing notes is currently 
glitched (especially with the Inverted Notes option).  Until that is fixed, I'm 
changing this enhancement's status to defect.

Original comment by raynebc on 9 Dec 2010 at 8:56

GoogleCodeExporter commented 9 years ago
Classic, Piano Roll and Hold input methods need to be updated to work with a 
sixth lane.

Original comment by raynebc on 9 Dec 2010 at 11:59

GoogleCodeExporter commented 9 years ago
As of r622, those input methods should be working with lane 6, and the 
rendering of the pen note is corrected.

Original comment by raynebc on 13 Dec 2010 at 3:33

GoogleCodeExporter commented 9 years ago
The sixth lane logic seems to be working just fine as per issue 116, including 
for transpose and toggle operations.  This should be easily adaptable for pro 
guitar charting.  The only rendering change that will require is updating the 
3D rendering for a sixth lane, but similar changes (scale the size of each lane 
based on the number of lanes present) can be made for the 3D window just as 
with the piano roll/fret catalog rendering.  Those changes will be tracked in 
issue #214.

Original comment by raynebc on 18 Dec 2010 at 2:06