search

m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Add missing lyric phrase markers #165

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As reported here:
http://www.fretsonfire.net/forums/viewtopic.php?f=3&t=49081&start=0#p553003

It has been claimed that FoFiX will hang if vocal charts are missing the phrase 
markers.  Since EOF now will correct freestyle lyrics, it may be a good idea to 
force the inclusion of line phrase markers or at least provide a warning during 
save, if no line phrases are defined.

Original issue reported on code.google.com by raynebc on 13 Sep 2010 at 10:36

GoogleCodeExporter commented 9 years ago 
r371 begins work on this issue.  Currently, it won't insert missing lyric 
phrases, but it will present a warning to the user when a save operation is 
attempted if any lyrics are defined outside of the existing lyric phrases.

The rest of the workaround would probably be something like:
When writing the MIDI events for each lyric, use FindLyricLine() to determine 
if a lyric is outside of all lyric phrases.  If so, write the events for a 
lyric phrase defined by the lyric's start time and length.  This will cause 
each stray lyric to get its own line phrase.  The warning could be changed to a 
prompt about whether the user wants to have the lyric phrases inserted to make 
a clean vocal track.  This prompt would probably have to be autonomous from the 
prompt to convert pitchless lyrics to freestyle lyrics.

Original comment by raynebc on 17 Sep 2010 at 9:33

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
The prompt to insert lyric phrases where they are missing was implemented in 
r489, but the previous warning that was set to prompt to continue saving in 
such a circumstance will need to be removed.

Original comment by raynebc on 22 Oct 2010 at 12:10

GoogleCodeExporter commented 9 years ago 
It might actually be a good idea to leave both prompts in, so the user can 
decide to cancel the save if they want to fix it properly.  I could add logic 
so that the inserted phrases will encompass multiple lyrics, but it would be 
difficult to determine how much space needs to be between two lyrics for them 
not to be in the same lyric phrase.  The best solution will remain as having 
the user set them correctly.

Original comment by raynebc on 22 Oct 2010 at 12:15

GoogleCodeExporter commented 9 years ago 
I'm going to consider this done.

Original comment by raynebc on 9 Jan 2011 at 10:04