search

m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

MIDI and lyric imports don't load vocal percussion notes #171

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This will just be a slight adjustment to the MIDI import logic.  Some moderate 
adjustments would need to be made to the lyric converter, but I can make the 
updated logic only run if EOF_BUILD is defined (ie. when it's being built with 
EOF).  The standalone converter needn't bother with vocal percussion.

Original issue reported on code.google.com by raynebc on 27 Sep 2010 at 6:16

GoogleCodeExporter commented 9 years ago 
The vocal percussion notes need special handling when EOF exports the MIDI.  
Currently, EOF is exporting an empty lyric string and then a note 96 on and 
off.  It should not export a lyric event at all in this circumstance.

Original comment by raynebc on 29 Sep 2010 at 8:22

GoogleCodeExporter commented 9 years ago 
r413 adds new lyric import logic to handle vocal percussion.  The code that 
hands off the lyrics to EOF needs to be updated to check for vocal percussion.  
When it finds it, it should discard the "*" lyric string.

Original comment by raynebc on 29 Sep 2010 at 8:50

GoogleCodeExporter commented 9 years ago 
Lyric import will now import vocal percussion notes, but due to FoFLC's design, 
such notes are enclosed within a lyric phrase.  This is unavoidable due to how 
FoFLC stores lyrics, but some logic could be written to remove them from the 
lyric phrase.  Since affected phrases are expected to begin on a vocal 
percussion note, this should make identifying the lyric phrases in question 
easy.  Any lyric phrase with a vocal percussion note as the first item could 
have its start time moved to the first non vocal percussion note in the phrase. 
 If no actual lyrics exist in the phrase (if the song ended in a vocal 
percussion section), the phrase should be deleted.

Original comment by raynebc on 30 Sep 2010 at 12:42

GoogleCodeExporter commented 9 years ago 
Remaining items for this issue:

1. Ensure that EOF doesn't write a lyric event for vocal percussion when saving 
the MIDI

2. Ensure that MIDI import will handle vocal percussion

3. Write a routine to run on the lyrics after lyric import to ensure that vocal 
percussion is removed from any lyric phrases.

Original comment by raynebc on 30 Sep 2010 at 6:04

GoogleCodeExporter commented 9 years ago 
Completed in r415.

Original comment by raynebc on 30 Sep 2010 at 6:26