m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Enforce a minimum note length of 1 delta tick #183

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I noticed that with the updated MIDI export logic, short notes can be written 
so that the Note Off appears 0 deltas away from the Note On event.  This may or 
may not work in FoF/Phase Shift, so it would probably be a good idea to come up 
with some kind of system to do this.  I can't immediately think of an efficient 
way besides storing the last delta time of each usable note, using an array of 
unsigned long variables.

Original issue reported on code.google.com by raynebc on 13 Oct 2010 at 6:22

GoogleCodeExporter commented 9 years ago
NewCreature indicated that FoF will correctly handle notes that are a length of 
0 deltas, provided that the events are in the proper order.  With that taken 
into consideration, this will become a non issue once EOF uses MIDI timing 
natively, as there will be no timing conversion that could result in a length 
of 0 deltas, notes will be a minimum length of 1 delta.  I'll consider this a 
non issue since there are no reported/foreseeable problems with leaving it 
as-is.

Original comment by raynebc on 14 Oct 2010 at 7:05