m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Make all lanes in crazy notes autonomous #211

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I was doing a quick bit of testing for the new PART KEYS handling, and I find 
that if I use grid snap to drag one note to the start position of another note, 
one of the notes' tails is changed to match the length of the other note.  
Notes in the non pro keys track need to be able to freely overlap and have 
independent lengths.

Another complication is how to change the length of one note but not the others 
if it is a chord, because all the notes' lengths are changed.

Original issue reported on code.google.com by raynebc on 28 Nov 2010 at 3:50

GoogleCodeExporter commented 9 years ago
Without investigating any further, I believe the easiest way to allow each lane 
to have its gem lengthened separately could be to treat each gem as a separate 
note instead of counting two notes as a chord when they begin at the same 
position.  This would allow each to be manipulated individually, but there 
would be occasions where the chart author would want them to be treated as 
chords.  Perhaps such functionality can be toggled on and off.  When the user 
toggles single key mode on (to allow fine adjustments of lanes instead of 
chords), each gem in the keys track is separated into a separate note (ie. a 3 
note chord turns into 3 notes).  When the user is completed, if multiple gems 
start at the same position and have the same length, they can be re-combined 
into a single chord.

I'll wager the reason that the original behavior I mentioned (when dragging one 
crazy note onto another, one lengthens or shortens to match the other) is 
because EOF is combining them into a single chord.

Original comment by raynebc on 30 Nov 2010 at 6:52

GoogleCodeExporter commented 9 years ago
It might even be easier to disallow "crazy" notes from being in chords.  This 
would reduce the complexity of the problem and hopefully allow for the most 
logical treatment of such notes.  This would also be a pre-cursor to pro keys 
logic, where each note is completely autonomous and can overlap other notes at 
will.

Original comment by raynebc on 30 Nov 2010 at 6:54

GoogleCodeExporter commented 9 years ago
Since the notes combining into one chord is probably by-design, I'll 
re-classify this as an enhancement to change how crazy notes are handled.  Even 
if crazy notes are prevented from joining into a single chord, EOF's logic was 
designed to select an existing note based on the mouse's X position, and not 
the Y position.

Original comment by raynebc on 30 Nov 2010 at 7:30

GoogleCodeExporter commented 9 years ago
The recently added eof_find_pen_note_mask() function sets eof_hover_piece to 
the lane number that the mouse is over.  This could make it easy to determine 
which of multiple crazy notes at the same chart position are being selected for 
manipulation.

Original comment by raynebc on 13 Dec 2010 at 9:12

GoogleCodeExporter commented 9 years ago

Original comment by raynebc on 4 Mar 2011 at 11:07

GoogleCodeExporter commented 9 years ago
On hold until I work on keys logic after the 1.8 stable release.

Original comment by raynebc on 4 Nov 2011 at 11:15