m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

A couple fret catalog enhancements #215

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Once the fret catalog rendering logic has been consolidated, there are some 
features I have been wanting to implement:

1. An option to have the fret catalog take up the 3D panel's space.  A keyboard 
combo such as ALT+Q could toggle this on and off, but it would allow better 
visibility for long catalog entries.

2. A button control or keyboard combo to seek to the current fret catalog 
entry's position.  This would save having to place a bookmark there.

3. Find next.  A function that will look for and seek to the next occurrence 
(from the current seek position) of the current fret catalog entry in the 
current instrument difficulty.  Timing will be ignored, and the search logic 
can just check for the notes being in the correct order to consider it a match.

Original issue reported on code.google.com by raynebc on 7 Dec 2010 at 1:31

GoogleCodeExporter commented 9 years ago
Task 1 should be as simple as recreating the note window to be twice as wide 
and to skip rendering the 3D window during each rendered frame.  Task 2 would 
probably just require adding a new button graphic and add logic to detect it 
being clicked, then performing the seek.  The eof_note_compare() function 
should make it easy to implement the find pattern logic for task 3.

Original comment by raynebc on 9 Jan 2011 at 10:57

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
4.  By default, a catalog entry should extend to the end of the entry's last 
note's tail.  Currently, it will stop playback just before the end of the last 
note, which is fine for long notes but is less useful for short notes.

5.  Provide a means to adjust the start and end timestamp of the catalog entry, 
either via clickable controls or keyboard shortcuts.

6.  Change the catalog naming so that the string comparison is case sensitive.  
As it currently is, if only letter case changes are made to the catalog entry 
name, EOF considers it to be the same as the original string and the changes 
are lost.

Original comment by raynebc on 6 Apr 2011 at 5:27

GoogleCodeExporter commented 9 years ago
"Find next" is a feature that I've been thinking would be particularly 
important recently.

Original comment by raynebc on 26 Jul 2012 at 7:40

GoogleCodeExporter commented 9 years ago
r938 completes task 3.  Tasks 2 and 6 were previously completed.  This leaves 
the following tasks to complete:

1. An option to have the fret catalog take up the 3D panel's space.  A keyboard 
combo such as ALT+Q could toggle this on and off, but it would allow better 
visibility for long catalog entries.  This should be as simple as recreating 
the note window to be twice as wide and to skip rendering the 3D window during 
each rendered frame.

4.  By default, a catalog entry should extend to the end of the entry's last 
note's tail.  Currently, it will stop playback just before the end of the last 
note, which is fine for long notes but is less useful for short notes.

5.  Provide a means to adjust the start and end timestamp of the catalog entry, 
either via clickable controls or keyboard shortcuts.

Original comment by raynebc on 9 Aug 2012 at 11:50

GoogleCodeExporter commented 9 years ago
r939 completes task 1.  Task 4 is irrelevant as the current logic will set the 
entry to end at the entry's last note, and will even pad it to 100ms after the 
start of the last note if the last note is shorter than 100ms.  This leaves the 
following task:

5.  Provide a means to adjust the start and end timestamp of the catalog entry, 
either via clickable controls or keyboard shortcuts.

Original comment by raynebc on 10 Aug 2012 at 7:13

GoogleCodeExporter commented 9 years ago
r1006 completes task 5 by adding a dialog menu to edit the timing for a fret 
catalog entry.  This completes this enhancement request.

Original comment by raynebc on 1 Nov 2012 at 10:24