search

m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Determine how to mark legacy trill and tremolo phrases #221

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Since these can be added to a non pro guitar track, it would be worthwhile to 
find how they are charting in RB3 MIDI files.  Once that is determined, the 
MIDI import and export logic can be updated, as EOF already supports charting 
them.

Original issue reported on code.google.com by raynebc on 29 Dec 2010 at 8:37

GoogleCodeExporter commented 9 years ago 
I couldn't find any mention of this in the RBN2 documentation, but there's a 
good chance that they use the same markers as "standard drum rolls" (note 126, 
a roll where all gems are in the same lane) and "special drum rolls" (note 127, 
a roll using multiple lanes):
http://creators.rockband.com/docs/Pro_Drum_Authoring#Drum_Rolls

I'd need to check some RB3 MIDIs on legacy guitar to confirm.  There are 
multiple trill phrases in one of the solos in "Crazy Train", and there are some 
trill phrases at about 7:00 in Roundabout.

Original comment by raynebc on 29 Dec 2010 at 9:05

GoogleCodeExporter commented 9 years ago 
My suspicions were correct, my analysis of the pro guitar MIDI track for 
"Foolin'" finds that tremolo phrases are marked with note 126 and trill phrases 
are marked with note 127.

Original comment by raynebc on 13 Jan 2011 at 8:20

GoogleCodeExporter commented 9 years ago 
r682 adds trill/tremolo MIDI import for pro guitar tracks.  Remaining tasks for 
this enhancement:

1. Implement MIDI import for legacy guitar tracks.  Test with RB3 charts.
2. Implement MIDI export for legacy and pro guitar tracks.
3. Update documentation.

Original comment by raynebc on 13 Jan 2011 at 9:05

GoogleCodeExporter commented 9 years ago 
Task #2 is partially complete in that pro guitar tracks can export these 
phrases.

Original comment by raynebc on 25 Jan 2011 at 12:44

GoogleCodeExporter commented 9 years ago 
r695 completes task #1.

Original comment by raynebc on 25 Jan 2011 at 8:10

GoogleCodeExporter commented 9 years ago 
Task #2 is completed in r696.  Now all that's left to do is document the use of 
trills, tremolos, drum rolls and special drum rolls.

Original comment by raynebc on 26 Jan 2011 at 10:10

GoogleCodeExporter commented 9 years ago 
The documentation was updated in r821.

Original comment by raynebc on 21 Aug 2011 at 9:15