Auto adjust displaces notes incorrectly

[GoogleCodeExporter]

r656 simplifies and abstracts the auto-adjust logic to better support EOF's new 
track handling and chart features.  Currently, it's a bit broken as notes are 
incorrectly displaced.  And even though I wrote logic for pro guitar notes to 
retain their fret values, this doesn't seem to work as the adjusted notes are 
stripped of their fret values.

Original issue reported on code.google.com by raynebc on 31 Dec 2010 at 9:02

[GoogleCodeExporter]

I have examined the values that get written to and read from eof.autoadjust, 
and this file's values seem to be handled correctly.  I've tracked the bug to 
eof_menu_edit_cut_paste(), specifically the calls that determine the position:

eof_put_porpos(temp_note.beat - first_beat[j] + this_beat[j], temp_note.porpos, 
0.0)

and length of the adjusted note:

eof_put_porpos(temp_note.endbeat - first_beat[j] + this_beat[j], 
temp_note.porendpos, 0.0) - eof_put_porpos(temp_note.beat - first_beat[j] + 
this_beat[j], temp_note.porpos, 0.0)

I haven't quite yet determined how the logic needs to be changed, but the 
position is getting incorrectly set to 0ms, and the value of the length is also 
set incorrectly even when the adjust shouldn't change the note's length.

Original comment by raynebc on 2 Jan 2011 at 8:01

• Added labels: Priority-Critical
• Removed labels: Priority-High

[GoogleCodeExporter]

r657 adds some debug code.

Original comment by raynebc on 2 Jan 2011 at 8:04

[GoogleCodeExporter]

Fixed in r665.

Original comment by raynebc on 8 Jan 2011 at 9:24

• Changed state: Fixed

[GoogleCodeExporter]

I found more flaws with the auto-adjust feature and fixed most of them in r666. 
 The remaining issue is that notes positioned at a beat marker that is moved 
aren't adjusted with the other notes, and are instead left where they are.

Original comment by raynebc on 8 Jan 2011 at 11:23

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in r667.

Original comment by raynebc on 9 Jan 2011 at 7:40

• Changed state: Fixed