search

m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Right clicking a lyric causes it to toggle between normal and pitchless state #234

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As reported here:
http://www.fretsonfire.net/forums/viewtopic.php?f=11&t=50698&start=60#p576897

In any input method BESIDES RexMundi, right clicking a lyric toggles its state 
rapidly until the right mouse button is released.

Original issue reported on code.google.com by raynebc on 5 Feb 2011 at 5:41

GoogleCodeExporter commented 9 years ago 
Through trace debugging, I tracked down the problem to 
eof_vocal_editor_logic().  Basically, when right click is used to change a 
lyric's pitch, the first pass through the vocal editor logic changes the pitch. 
 The second pass sees that a lyric was right clicked on its already existing 
pitch and follows its programming to set the lyric's pitch to 0.  The third 
pass changes the lyric's pitch.  Until the right mouse button is released, the 
second and third passes repeat endlessly, having the effecting of toggling a 
lyric between pitched and pitchless.

I haven't worked out how best to correct this, but the right mouse button will 
need to be tracked so that only a new right click on the existing lyric's 
current pitch will set it to be pitchless.

Original comment by raynebc on 13 Feb 2011 at 6:43

GoogleCodeExporter commented 9 years ago 
Fixed in r814.

Original comment by raynebc on 13 Aug 2011 at 5:28