m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Improve BRE functionality #238

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
As requested here:
http://www.fretsonfire.net/forums/viewtopic.php?f=11&t=32725&p=578104#p578102

I agree that this could made easier if notes authored in the BRE tab are 
automatically made 5 note chords.  This would probably be as easy as updating 
the note creation logic to force a 5 lane bitmask if the BRE difficulty is 
active, and updating the fixup logic to force all notes in the BRE difficulty 
to be 5 note chords.

It could also be useful to automatically prompt the user if a BRE phrase in 
PART DRUMS is a drum roll or a BRE, or make it a toggle-able option that is 
stored as a phrase status flag.  During MIDI export, the appropriate big rock 
ending text event will be exported.  This would be an improvement not only 
because it's easier for the user, but it would allow for BRE's to be authored 
when they don't start exactly on a beat marker.

It might even be worth adding 2D and 3D rendering of BRE phrases.  At least for 
drum rolls, it will make it easier to keep track of them during the authoring 
process.  All of the 2D fretboard area is currently allocating for displaying 
trill/tremolo, star power and overdrive phrases, but the unused background area 
of the editor window could be rendered in a color other than gray (render 
before the fretboard is drawn so that it is visible in the fretboard area where 
possible).

The 3D rendering could be made to resemble Rock Band or FoFiX.  BREs have 
phrase rendering in all 5 lanes, and drum rolls have a light colored fret board.

I have uncommitted additions to EOF's manual for creating big rock endings and 
drum rolls that will be added soon, but new documentation would be needed to 
accommodate for any above-mentioned improvements added.

Original issue reported on code.google.com by raynebc on 12 Feb 2011 at 9:46

GoogleCodeExporter commented 9 years ago
In addition:

Various note based operations should be disabled for notes in the BRE tab for 
any instrument track: Toggle, Transpose (should be disabled automatically when 
BRE notes are forced as 5 note chords), Solos, Star Power, Pro drum functions, 
Special drum roll, Drum roll, Toggle crazy, HOPO, Pro guitar functions, Trill, 
Tremolo.

There can be a Note>"Mark BRE" menu function that will insert a 
"big_rock_ending" section marker where appropriate when authoring the drum 
track.  This should automatically get applied to any BRE note in a non drum 
track, because it's the only valid way to use it for other instruments.  The 
logic that applies the big rock ending would need to resolve conflicts as 
necessary (delete any other BRE notes in a non drum track, or remove BRE status 
from any other BRE notes in the drum track), and would probably need to apply a 
flag to the note.  Since note statuses do not affect BRE notes, any of the note 
flags already in use can be shared for BRE notes.

Any marked big rock ending could be given the name "BRE" so that the 2D and 3D 
note rendering functions will display "BRE" appropriately.

Note sanitization needs to be performed on notes pasted into the BRE tab (all 
flags cleared), and it wouldn't hurt for the note fixup logic to automatically 
remove any status except that which might be used for notating a big rock 
ending.

Original comment by raynebc on 23 Feb 2011 at 3:48

GoogleCodeExporter commented 9 years ago
Pro guitar/bass BREs apparently use all 6 lanes.  Any logic that forced notes 
in the BRE tab of a pro guitar/bass track would need to force all 6 lanes 
instead of just the first 5.

Original comment by raynebc on 16 Jul 2011 at 8:04