m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

MIDI import crash and double bass load bug #240

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
eodeth posted a chart that causes EOF to crash if the MIDI is imported:
http://www.mediafire.com/?0m1z17c08aqfosd

Unfortunately, when I try to replicate when EOF is debugging, no crash occurs.  
I might be doing it wrong, but if I attach the debugger to the eof.exe process 
after I already caused the crash, the call stack doesn't seem to be correct.

I find that if I re-save the chart, it doesn't seem to crash when I import the 
MIDI.  Even if a MIDI export problem was corrected, it doesn't change that the 
crash vulnerability is there..

Original issue reported on code.google.com by raynebc on 1 Mar 2011 at 10:09

GoogleCodeExporter commented 9 years ago
I also find that when I loaded the chart in the current revision of EOF, the 
double bass drum notes are not shown, even though they show when I open the 
exact same chart file in EOF 1.71.

Original comment by raynebc on 1 Mar 2011 at 10:14

GoogleCodeExporter commented 9 years ago

Original comment by raynebc on 1 Mar 2011 at 10:15

GoogleCodeExporter commented 9 years ago
r714 corrects the import of double bass drum notes from legacy project files.  
Before version 1.8, the project format marked this status with the crazy flag 
(which drum notes couldn't have).

More debugging may be necessary to track down the point of crash, perhaps check 
point information can be updated in the program window's title bar.

Original comment by raynebc on 2 Mar 2011 at 12:15

GoogleCodeExporter commented 9 years ago
A different problem seems to be that when a MIDI is imported, double bass drum 
notes aren't marked as double bass anymore after the import completes.

Original comment by raynebc on 2 Mar 2011 at 12:34

GoogleCodeExporter commented 9 years ago
r715 adds more debugging and fixes the double bass problem.  Since the crash 
can no longer be reproduced, I'll close this issue.

Original comment by raynebc on 3 Mar 2011 at 8:19