m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

feature req: GP5 Import tie+slide as separated notes w/ linknext + slide #283

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. import a gp5 file w/ a tie followed by a slide (img 1)
2. tied notes are collapsed, so slide starts at the beginning of the note 
instead of at the 2nd tied note (img 2)

What is the expected output? What do you see instead?
tied notes should be separated & linked w/ linknext, so that slide begins at 
appropriate beat (img 3)

What version of the product are you using? On what operating system?
latest Mac build (1.8RC9)

Original issue reported on code.google.com by ea.th1rtyf0ur on 5 Mar 2014 at 5:45

Attachments:

GoogleCodeExporter commented 8 years ago
(this may apply to other techniques besides slides)

Original comment by ea.th1rtyf0ur on 5 Mar 2014 at 5:47

GoogleCodeExporter commented 8 years ago
If I implemented this change, it would probably only create a linked note if 
the tie note has any techniques that the original note didn't have.  How does 
that sound?

Original comment by raynebc on 6 Mar 2014 at 6:51

GoogleCodeExporter commented 8 years ago
Yes, that's the only situation it would make sense. In this case, the slide 
applies to the 2nd tied notes (in the 3-10 and 2-9 slides), but not to the 
first, which affects when the slide shows up in the eventual RS export. The 
same would likely apply to vibrato, tremolo, etc. although those could possibly 
be placed as tech notes instead of linknext "ties". Slide placement can only be 
done w/ linknext AFAIK since placing a slide tech note would still only affect 
it at the beginning of the note, regardless of where it was placed- right? I'm 
not sure which other note statuses affect the whole note vs which only start 
where the tech note is placed.

Original comment by ea.th1rtyf0ur on 6 Mar 2014 at 7:35

GoogleCodeExporter commented 8 years ago
This was implemented in r1342 and r1349.  Is it working properly for you?

Original comment by raynebc on 17 Dec 2014 at 9:53

GoogleCodeExporter commented 8 years ago
I'll assume it is for now.

Original comment by raynebc on 1 Jan 2015 at 3:18

GoogleCodeExporter commented 8 years ago
Sorry for the late reply, been a while since I've done any CDLC work. Confirmed 
that it's working now (using r1369).

Original comment by ea.th1rtyf0ur on 28 Jan 2015 at 3:49