Unexpected crash/glitch with "Erase all" lyric lines

[GoogleCodeExporter]

Intermittently, I've been able to cause a crash or an unexpected deletion
of all lyrics by performing Note>Lyric Lines>Erase all, making a selection
of lyrics and marking a line phrase.  If it didn't crash/delete then,
sometimes exiting without save would cause EOF to crash.

Original issue reported on code.google.com by raynebc on 15 May 2010 at 10:55

[GoogleCodeExporter]

I still haven't found the exact conditions to replicate this on demand, although
trying similar steps in random fashion has allowed me to cause a crash several 
times.

Original comment by raynebc on 16 May 2010 at 8:06

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

I found by selecting a phrase's worth of notes, performing an "Erase All" lyric 
lines
and then trying to mark the already-selected notes as a phrase again, EOF ended 
up
deleting all lyrics.  At this point, all sorts of weird things are possible 
because
EOF calls eof_vocal_track_delete_line() in the line marking function even when 
there
are 0 lines, and that function decrements eof_song->vocal_track->lines.

Original comment by raynebc on 17 May 2010 at 12:18

[GoogleCodeExporter]

Some flawed logic that would conceivably cause this behavior (including an out 
of
bounds memory access) has been corrected in r135.

Original comment by raynebc on 17 May 2010 at 12:26

• Changed state: Fixed