search

m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

MIDI import misses some notes/lyrics and alters lyric durations #81

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
EOF's MIDI import seems to misread lyric text/phrases.  In White Wedding
(notes-united.mid):

1:41    The lyric "It's" doesn't get read
2:27    The lyric text "Pick^" doesn't get read
2:40    The lyric text "Oh#" doesn't get read, and the next lyric phrase
("I've been away for so long) doesn't get marked for overdrive

Here's the chart and audio for White Wedding:
http://www.sendspace.com/file/ia34jc

Original issue reported on code.google.com by raynebc on 15 May 2010 at 9:18

GoogleCodeExporter commented 9 years ago 
The current documentation specifies that lyrics/phrases might get missed by 
EOF's
native MIDI import if the MIDI file has severe enough errors.  The workaround 
to try
the lyric import feature is given, and would be the best thing I can suggest.  I
wouldn't be as worried about the missing lyrics as that the overdrive status 
got lost.

Original comment by raynebc on 16 May 2010 at 8:09

GoogleCodeExporter commented 9 years ago 
As reported here:
http://www.fretsonfire.net/forums/viewtopic.php?p=527560#p527534

I tested the chart posted by mrstuprigge, and when MIDI import is performed on
notes.mid and compared against loading the EOF file for the chart, several 
guitar
notes (possibly others) are not loaded, and the durations of all lyrics are 
altered.
 I tried resaving the EOF file and importing that MIDI, but the problem persisted.  I
don't know if it's a problem with the MIDI export or the MIDI import without 
spending
more time to investigate it.

Original comment by raynebc on 1 Jun 2010 at 6:43

GoogleCodeExporter commented 9 years ago

Original comment by raynebc on 1 Jun 2010 at 6:43

GoogleCodeExporter commented 9 years ago 
After looking at the MIDI, I see that the lyrics were exported during save with
durations of 1ms each.  At this point, I still haven't verified if the missing 
guitar
notes were omitted during export or dropped during import.

Original comment by raynebc on 1 Jun 2010 at 8:08

GoogleCodeExporter commented 9 years ago 
I have experimented this issue too, every time I import a MIDI file, some notes 
at the end of the song disappear.
It happens every time I import a MIDI

Original comment by flowerz....@gmail.com on 11 Jul 2010 at 2:57

GoogleCodeExporter commented 9 years ago 
Doomtron confirmed this problem:
http://www.fretsonfire.net/forums/viewtopic.php?f=11&t=32725&view=unread&sid=12b
2fe843977b72a7b1bbaa1cec3c3d3#p540353

and posted a chart that exhibits this issue:
http://www.mediafire.com/?ltweu6w812um16e

When the EOF file is opened, PART DRUMS has notes clear up to 4:19, but when 
the chart is saved and the MIDI file is opened, there are no drum notes loaded 
beyond about 4:11.  The MIDI file does seem to contain all the notes as 
expected, but the import is not loading the complete file.  Also, a small 
issue, but my converter and Reaper agree that the final note (a green+purple 
combo) is placed at 4:18.952, but EOF gives the position as 4:18.956.

Original comment by raynebc on 26 Jul 2010 at 1:28

GoogleCodeExporter commented 9 years ago 
While trying to create a simple chart to test issue 123 with, I ended up 
creating a chart that misses a Note Off during import, causing a subsequent 
note to not be shown after import.  The glitched note extends all the way to 
the right end of the piano roll.  The chart is here:
http://www.sendspace.com/file/9h73v3

Original comment by raynebc on 1 Aug 2010 at 7:24

GoogleCodeExporter commented 9 years ago 
r265 fixes the import issues demonstrated with Doomtron's chart and my test 
chart.  I believe the original import issue with RB MIDIs (such as "White 
Wedding") are still present.

Original comment by raynebc on 2 Aug 2010 at 7:40

GoogleCodeExporter commented 9 years ago 
The original issue has only been seen to occur during PART VOCALS import for RB 
MIDIs.  I'm going to restore the previous priority for this issue.

Original comment by raynebc on 2 Aug 2010 at 8:13

GoogleCodeExporter commented 9 years ago 
This issue cannot realistically be fixed unless EOF implements strong error 
correction for imported lyrics, along the lines of the corrections performed by 
foflc.  EOF's documentation already states the limitation and isn't meant to 
specialize so heavily in lyric sanitization.  Since the lyric import as a 
workaround, I'll close this issue.  If EOF is ever found to have problems 
importing a vocal track that it created itself, we'll examine the issue then.

Original comment by raynebc on 31 Aug 2010 at 7:57