search

m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

MP3->Ogg conversion is broken in Windows build #88

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I was able to replicate the issue reported by amak11 here:
http://www.fretsonfire.net/forums/viewtopic.php?f=11&t=32725&p=524977#p524961

Perhaps there's a slight syntax error in the batch file that gets launched
in the Windows version of EOF.

Original issue reported on code.google.com by raynebc on 20 May 2010 at 6:47

GoogleCodeExporter commented 9 years ago 
Does it always fail or is it subject to certain conditions?

Original comment by xander4j...@yahoo.com on 21 May 2010 at 10:10

GoogleCodeExporter commented 9 years ago 
I didn't test a lot of configurations, but I wasn't able to get it to work.  I 
can
try to debug further to try to get the contents of the batch file if you want.

Original comment by raynebc on 21 May 2010 at 10:32

GoogleCodeExporter commented 9 years ago 
I didn't change the batch file at all. Is the conversion happening at all or is 
it 
just failing altogether?

Original comment by xander4j...@yahoo.com on 21 May 2010 at 10:43

GoogleCodeExporter commented 9 years ago 
I think the conversion isn't happening because EOF prompts for the OGG file to 
be
located, which is consistent with the last time the conversion feature broke.

Original comment by raynebc on 21 May 2010 at 10:45

GoogleCodeExporter commented 9 years ago 
What I mean is does it take any time to fail? If it is converting it should 
take a few 
seconds before it fails.

Original comment by xander4j...@yahoo.com on 22 May 2010 at 12:07

GoogleCodeExporter commented 9 years ago 
It fails immediately.  I added a pause to the batch file that EOF runs in the 
Windows
build.  Here's what it displays:

Using LAME and OggEnc to convert from MP3 to OGG.

Input:  "D:\downloads\FretsOnFire\songs\My songs\TEST\30.06 - Styx - Mr. Roboto.
mp3"
Output: "D:\downloads\FretsOnFire\songs\My songs\test2 - test2\guitar.ogg"

This may take a minute or two. Please be patient.
ERROR: Input file "(stdin)" is not a supported format
Press any key to continue . . .

I haven't fought with the command line parameters for LAME and OGGENC2 to see 
what
changes the syntax needs.

Original comment by raynebc on 22 May 2010 at 12:23

GoogleCodeExporter commented 9 years ago 
I think I see the problem:

delete_file("eoftemp.mp3") gets called before eof_system(syscommand)

Original comment by raynebc on 22 May 2010 at 12:33

GoogleCodeExporter commented 9 years ago 
Fixed in r163

Original comment by raynebc on 22 May 2010 at 12:36