m0j0hn / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Enhance custom grid snap #99

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Being able to set a per-measure grid snap would be useful for some folks,
as EOF's current custom grid snap only allows per-beat values.

Original issue reported on code.google.com by raynebc on 22 May 2010 at 9:17

GoogleCodeExporter commented 9 years ago
r170 starts this issue

Remaining work involves getting it to work properly, as EOF seems to require a
minimum of 1/4 measure grid snap value, and the sustains aren't working quite 
right
yet.  I'd also like to make the custom grid snap dialog window keep the previous
radio button set ("measure" or "beat") since the last specified number is shown.

Original comment by raynebc on 22 May 2010 at 9:20

GoogleCodeExporter commented 9 years ago
Also, the "per measure" radio button should probably be disabled if the Time
Signature hasn't been set, since a default TS of 4/4 is not currently assumed 
in EOF.

Original comment by raynebc on 22 May 2010 at 9:23

GoogleCodeExporter commented 9 years ago
r171 continues this issue

The "measure" and "beat" radio buttons retain the last set value between edits 
of the
custom grid snap value.

Original comment by raynebc on 23 May 2010 at 10:54

GoogleCodeExporter commented 9 years ago
For this to work you will probably need to find the start and end times of the 
measure 
in which time 'p' (passed to eof_snap_logic() function) is located. Then you 
can just 
split up the total time by the specified interval and find the closest snap 
position 
to 'p'. You would have to apply the same technique in eof_snap_length_logic(). 
Are you 
still working on this issue?

Original comment by xander4j...@yahoo.com on 24 May 2010 at 8:30

GoogleCodeExporter commented 9 years ago
Eventually I might.  It would probably take me longer to figure out than it 
would
take you.

Original comment by raynebc on 24 May 2010 at 8:44

GoogleCodeExporter commented 9 years ago
The reason I ask is because it is marked as "Started." I didn't want to mess 
with it 
if you were working on it.

Original comment by xander4j...@yahoo.com on 24 May 2010 at 9:47

GoogleCodeExporter commented 9 years ago
Feel free.  I've gotten into a bad habit of leaving an issue in started if I 
have
worked on it and plan to come back to it later.

Original comment by raynebc on 24 May 2010 at 10:21

GoogleCodeExporter commented 9 years ago

Original comment by xander4j...@yahoo.com on 25 May 2010 at 8:23

GoogleCodeExporter commented 9 years ago

Original comment by xander4j...@yahoo.com on 25 May 2010 at 9:14

GoogleCodeExporter commented 9 years ago
I found that a very slight issue exists in this a custom grid snap per measure
doesn't track quite right between tempo changes.  For example, if I set a grid 
snap
of 1/5 measure, and place 5 consecutive 1/5 measure notes, the end of the fifth 
note
doesn't end at the end of the measure if there are tempo changes within the 
measure.
 This can be manually corrected by dragging the affected notes to the correct grid
snap position.

Original comment by raynebc on 26 May 2010 at 2:49

GoogleCodeExporter commented 9 years ago

Original comment by xander4j...@yahoo.com on 26 May 2010 at 8:24

GoogleCodeExporter commented 9 years ago

Original comment by xander4j...@yahoo.com on 26 May 2010 at 8:40