m0ngr31 / kanzi

Alexa skill for controlling Kodi
https://lexigr.am
MIT License
427 stars 149 forks source link

Accept unicode in slots. #165

Closed jingai closed 7 years ago

jingai commented 7 years ago

This, in conjunction with m0ngr31/kodi-voice/pull/3, allows unicode in the slots that get passed to the skill.

These changes should address #113.

mcl22 commented 7 years ago

yes and in artists, too

jingai commented 7 years ago

There is nothing different between them though

mcl22 commented 7 years ago

Well, to me it's no problem anymore since with new alexa.py I don't get any unicode errors anymore. And since "Komödie" is the only genre including an umlaut I manually changed it and it's ok. I also don't know what I could investigate there anymore except looking into the code. And that's what you did :) I just can tell you if I run the script it performs correctly for artists, albums and all of them but not for movie genres. The web generator doesn't have this problem as mentioned yesterday.

jingai commented 7 years ago

I can't figure out why it'd be different from the other requests :/

jingai commented 7 years ago

I opened #172 to document what I've found regarding string encodings from Kodi.