search

m0ngr31 / kanzi

Alexa skill for controlling Kodi
https://lexigr.am
MIT License
427 stars 149 forks source link

Add DownloadSubtitles intent #205

Closed rinzeb closed 7 years ago

rinzeb commented 7 years ago

Added an intent for downloading subtitles. When playing a show or movie, this will open the "Download subtitles" window, where you can download a subtitle from one of your enabled subtitle addons. I prefer to enable the Kodi setting "Automatically download the first subtitle" in order to download subtitles with just 1 voice command. Alternatively, this requires a "Select" command to download a subtitle. (Related to issue #49 )

rinzeb commented 7 years ago

Requires a PR on kodi-voice too: https://github.com/m0ngr31/kodi-voice/pull/16

jingai commented 7 years ago

Thanks for the PR.

I don't think we should use "search for" here though, since that's how we invoke the Global Search addon.

jingai commented 7 years ago

Should this return question()? If the auto-download-first-available option is enabled, it doesn't pop a dialog, but there's not really any way for the skill to know that.

jingai commented 7 years ago

Merged with the above changes. Thanks again!